Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inter font and update packages #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iggy890
Copy link

@iggy890 iggy890 commented Mar 3, 2023

This PR closes this issue by changing the SF Pro Text font to the Inter font.

@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
codeedit-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 9:18PM (UTC)

@austincondiff
Copy link
Contributor

You are not pulling in Inter. The way you have it, the user would need to have it installed on their system. We need to pull Inter in from Google Fonts. In order to do this, we need to do this how Next.js recommends you do it here.

@iggy890 iggy890 changed the title Add Inter font Add Inter font and update packages Mar 4, 2023
@noClaps
Copy link

noClaps commented Jan 7, 2024

You are not pulling in Inter. The way you have it, the user would need to have it installed on their system. We need to pull Inter in from Google Fonts. In order to do this, we need to do this how Next.js recommends you do it here.

Actually, the creator of Inter recommends against using Google Fonts since it doesn't have italics. The recommended way is to either self-host the files from Releases, or to use his CDN distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font choice
3 participants